Skip to content

Commit

Permalink
Revert "bridge: Use hlist_for_each_entry_rcu() in br_multicast_add_ro…
Browse files Browse the repository at this point in the history
…uter()"

This reverts commit ff65e82.

As explained by Stephen Hemminger, the traversal doesn't require
RCU handling as we hold a lock.

The list addition et al. calls, on the other hand, do.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Apr 27, 2010
1 parent 2a1f879 commit 709b932
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bridge/br_multicast.c
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ static void br_multicast_add_router(struct net_bridge *br,
struct net_bridge_port *p;
struct hlist_node *n, *last = NULL;

hlist_for_each_entry_rcu(p, n, &br->router_list, rlist) {
hlist_for_each_entry(p, n, &br->router_list, rlist) {
if ((unsigned long) port >= (unsigned long) p) {
hlist_add_before_rcu(n, &port->rlist);
return;
Expand Down

0 comments on commit 709b932

Please sign in to comment.