Skip to content

Commit

Permalink
USB: ohci-jz4740: remove unnecessary platform_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d06
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jingoo Han authored and Greg Kroah-Hartman committed May 17, 2013
1 parent 2f2f2fa commit 70caa52
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/usb/host/ohci-jz4740.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ static int jz4740_ohci_probe(struct platform_device *pdev)
return 0;

err_disable:
platform_set_drvdata(pdev, NULL);
if (jz4740_ohci->vbus) {
regulator_disable(jz4740_ohci->vbus);
regulator_put(jz4740_ohci->vbus);
Expand All @@ -246,8 +245,6 @@ static int jz4740_ohci_remove(struct platform_device *pdev)

usb_remove_hcd(hcd);

platform_set_drvdata(pdev, NULL);

if (jz4740_ohci->vbus) {
regulator_disable(jz4740_ohci->vbus);
regulator_put(jz4740_ohci->vbus);
Expand Down

0 comments on commit 70caa52

Please sign in to comment.