---

yaml --- r: 203655 b: refs/heads/master c: 4b70637 h: refs/heads/master i: 203653: 4a8f08c 203651: bc706a5 203647: de843db v: v3
git-mirror · Jul 20, 2010 · 70dbdc3 · 70dbdc3
1 parent 52ce80b
commit 70dbdc3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: d79d991379af35d43f003f162e8650e72965b8ca
+refs/heads/master: 4b706372f18de53970e4c6887a96459590fef80a
diff --git a/trunk/net/core/drop_monitor.c b/trunk/net/core/drop_monitor.c
@@ -223,6 +223,11 @@ static int set_all_monitor_traces(int state)
 
 	spin_lock(&trace_state_lock);
 
+	if (state == trace_state) {
+		rc = -EAGAIN;
+		goto out_unlock;
+	}
+
 	switch (state) {
 	case TRACE_ON:
 		rc |= register_trace_kfree_skb(trace_kfree_skb_hit, NULL);
@@ -251,11 +256,12 @@ static int set_all_monitor_traces(int state)
 
 	if (!rc)
 		trace_state = state;
+	else
+		rc = -EINPROGRESS;
 
+out_unlock:
 	spin_unlock(&trace_state_lock);
 
-	if (rc)
-		return -EINPROGRESS;
 	return rc;
 }