Skip to content

Commit

Permalink
cpufreq: exynos5440: Protect OPP search calls with RCU lock
Browse files Browse the repository at this point in the history
As per the OPP library documentation(Documentation/power/opp.txt) all
OPP find/get calls should be protected by RCU locks.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Amit Daniel Kachhap authored and Rafael J. Wysocki committed Apr 21, 2013
1 parent c778966 commit 70eb085
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/cpufreq/exynos5440-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,13 @@ static int init_div_table(void)
int i = 0;
struct opp *opp;

rcu_read_lock();
for (i = 0; freq_tbl[i].frequency != CPUFREQ_TABLE_END; i++) {

opp = opp_find_freq_exact(dvfs_info->dev,
freq_tbl[i].frequency * 1000, true);
if (IS_ERR(opp)) {
rcu_read_unlock();
dev_err(dvfs_info->dev,
"failed to find valid OPP for %u KHZ\n",
freq_tbl[i].frequency);
Expand Down Expand Up @@ -159,6 +161,7 @@ static int init_div_table(void)
__raw_writel(tmp, dvfs_info->base + XMU_PMU_P0_7 + 4 * i);
}

rcu_read_unlock();
return 0;
}

Expand Down

0 comments on commit 70eb085

Please sign in to comment.