Skip to content

Commit

Permalink
sched: remove duplicate code from sched_fair.c
Browse files Browse the repository at this point in the history
pick_task_entity() duplicates existing code. This functionality can be
easily obtained using rb_last(). Avoid code duplication by using rb_last().

Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Balbir Singh authored and Ingo Molnar committed Feb 25, 2008
1 parent 6892b75 commit 70eee74
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions kernel/sched_fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -202,16 +202,13 @@ static struct sched_entity *__pick_next_entity(struct cfs_rq *cfs_rq)

static inline struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq)
{
struct rb_node **link = &cfs_rq->tasks_timeline.rb_node;
struct sched_entity *se = NULL;
struct rb_node *parent;

while (*link) {
parent = *link;
se = rb_entry(parent, struct sched_entity, run_node);
link = &parent->rb_right;
}
struct rb_node *last;
struct sched_entity *se;

last = rb_last(&cfs_rq->tasks_timeline);
if (!last)
return NULL;
se = rb_entry(last, struct sched_entity, run_node);
return se;
}

Expand Down

0 comments on commit 70eee74

Please sign in to comment.