Skip to content

Commit

Permalink
netns bridge: cleanup bridges during netns stop
Browse files Browse the repository at this point in the history
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Acked-by: Stephen Hemminger <shemming@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexey Dobriyan authored and David S. Miller committed Sep 8, 2008
1 parent 4aa678b commit 712d695
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 9 deletions.
22 changes: 16 additions & 6 deletions net/bridge/br.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ static const struct stp_proto br_stp_proto = {
.rcv = br_stp_rcv,
};

static struct pernet_operations br_net_ops = {
.exit = br_net_exit,
};

static int __init br_init(void)
{
int err;
Expand All @@ -42,29 +46,35 @@ static int __init br_init(void)
if (err)
goto err_out;

err = br_netfilter_init();
err = register_pernet_subsys(&br_net_ops);
if (err)
goto err_out1;

err = register_netdevice_notifier(&br_device_notifier);
err = br_netfilter_init();
if (err)
goto err_out2;

err = br_netlink_init();
err = register_netdevice_notifier(&br_device_notifier);
if (err)
goto err_out3;

err = br_netlink_init();
if (err)
goto err_out4;

brioctl_set(br_ioctl_deviceless_stub);
br_handle_frame_hook = br_handle_frame;

br_fdb_get_hook = br_fdb_get;
br_fdb_put_hook = br_fdb_put;

return 0;
err_out3:
err_out4:
unregister_netdevice_notifier(&br_device_notifier);
err_out2:
err_out3:
br_netfilter_fini();
err_out2:
unregister_pernet_subsys(&br_net_ops);
err_out1:
br_fdb_fini();
err_out:
Expand All @@ -80,7 +90,7 @@ static void __exit br_deinit(void)
unregister_netdevice_notifier(&br_device_notifier);
brioctl_set(NULL);

br_cleanup_bridges();
unregister_pernet_subsys(&br_net_ops);

synchronize_net();

Expand Down
4 changes: 2 additions & 2 deletions net/bridge/br_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,13 +446,13 @@ int br_del_if(struct net_bridge *br, struct net_device *dev)
return 0;
}

void __exit br_cleanup_bridges(void)
void br_net_exit(struct net *net)
{
struct net_device *dev;

rtnl_lock();
restart:
for_each_netdev(&init_net, dev) {
for_each_netdev(net, dev) {
if (dev->priv_flags & IFF_EBRIDGE) {
del_br(dev->priv);
goto restart;
Expand Down
2 changes: 1 addition & 1 deletion net/bridge/br_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ extern void br_flood_forward(struct net_bridge *br, struct sk_buff *skb);
extern void br_port_carrier_check(struct net_bridge_port *p);
extern int br_add_bridge(struct net *net, const char *name);
extern int br_del_bridge(struct net *net, const char *name);
extern void br_cleanup_bridges(void);
extern void br_net_exit(struct net *net);
extern int br_add_if(struct net_bridge *br,
struct net_device *dev);
extern int br_del_if(struct net_bridge *br,
Expand Down

0 comments on commit 712d695

Please sign in to comment.