Skip to content

Commit

Permalink
V4L/DVB (11419): gspca - m5602-ov9650: Don't read exposure data from …
Browse files Browse the repository at this point in the history
…COM1.

ov9650: Reading the COM1 register corrupts the image.
Decrease the granularity of the exposure and limit its upper range
as setting such high values doesn't have any effect on the image.

Signed-off-by: Erik Andr?n <erik.andren@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Erik Andr?n authored and Mauro Carvalho Chehab committed Apr 7, 2009
1 parent 5a0489b commit 7136e70
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 2 additions & 7 deletions drivers/media/video/gspca/m5602/m5602_ov9650.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ const static struct ctrl ov9650_ctrls[] = {
.type = V4L2_CTRL_TYPE_INTEGER,
.name = "exposure",
.minimum = 0x00,
.maximum = 0xffff,
.step = 0x1,
.maximum = 0x1ff,
.step = 0x4,
.default_value = EXPOSURE_DEFAULT,
.flags = V4L2_CTRL_FLAG_SLIDER
},
Expand Down Expand Up @@ -407,11 +407,6 @@ int ov9650_get_exposure(struct gspca_dev *gspca_dev, __s32 *val)
u8 i2c_data;
int err;

err = m5602_read_sensor(sd, OV9650_COM1, &i2c_data, 1);
if (err < 0)
return err;
*val = i2c_data & 0x03;

err = m5602_read_sensor(sd, OV9650_AECH, &i2c_data, 1);
if (err < 0)
return err;
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/gspca/m5602/m5602_ov9650.h
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
#define GAIN_DEFAULT 0x14
#define RED_GAIN_DEFAULT 0x70
#define BLUE_GAIN_DEFAULT 0x20
#define EXPOSURE_DEFAULT 0x5003
#define EXPOSURE_DEFAULT 0x1ff

/*****************************************************************************/

Expand Down

0 comments on commit 7136e70

Please sign in to comment.