Skip to content

Commit

Permalink
[PATCH] xen: x86: Use more usermode macro
Browse files Browse the repository at this point in the history
Use the user_mode macro where it's possible.

Signed-off-by: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Vincent Hanquez authored and Linus Torvalds committed Jun 23, 2005
1 parent fa1e1bd commit 717b594
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ void show_regs(struct pt_regs * regs)
printk("EIP: %04x:[<%08lx>] CPU: %d\n",0xffff & regs->xcs,regs->eip, smp_processor_id());
print_symbol("EIP is at %s\n", regs->eip);

if (regs->xcs & 3)
if (user_mode(regs))
printk(" ESP: %04x:%08lx",0xffff & regs->xss,regs->esp);
printk(" EFLAGS: %08lx %s (%s)\n",
regs->eflags, print_tainted(), system_utsname.release);
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ int fastcall do_signal(struct pt_regs *regs, sigset_t *oldset)
* kernel mode. Just return without doing anything
* if so.
*/
if ((regs->xcs & 3) != 3)
if (!user_mode(regs))
return 1;

if (current->flags & PF_FREEZE) {
Expand Down
12 changes: 6 additions & 6 deletions arch/i386/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ void show_registers(struct pt_regs *regs)

esp = (unsigned long) (&regs->esp);
ss = __KERNEL_DS;
if (regs->xcs & 3) {
if (user_mode(regs)) {
in_kernel = 0;
esp = regs->esp;
ss = regs->xss & 0xffff;
Expand Down Expand Up @@ -266,7 +266,7 @@ static void handle_BUG(struct pt_regs *regs)
char c;
unsigned long eip;

if (regs->xcs & 3)
if (user_mode(regs))
goto no_bug; /* Not in kernel */

eip = regs->eip;
Expand Down Expand Up @@ -354,7 +354,7 @@ void die(const char * str, struct pt_regs * regs, long err)

static inline void die_if_kernel(const char * str, struct pt_regs * regs, long err)
{
if (!(regs->eflags & VM_MASK) && !(3 & regs->xcs))
if (!user_mode_vm(regs))
die(str, regs, err);
}

Expand All @@ -367,7 +367,7 @@ static void do_trap(int trapnr, int signr, char *str, int vm86,
goto trap_signal;
}

if (!(regs->xcs & 3))
if (!user_mode(regs))
goto kernel_trap;

trap_signal: {
Expand Down Expand Up @@ -489,7 +489,7 @@ fastcall void do_general_protection(struct pt_regs * regs, long error_code)
if (regs->eflags & VM_MASK)
goto gp_in_vm86;

if (!(regs->xcs & 3))
if (!user_mode(regs))
goto gp_in_kernel;

current->thread.error_code = error_code;
Expand Down Expand Up @@ -716,7 +716,7 @@ fastcall void do_debug(struct pt_regs * regs, long error_code)
* check for kernel mode by just checking the CPL
* of CS.
*/
if ((regs->xcs & 3) == 0)
if (!user_mode(regs))
goto clear_TF_reenable;
}

Expand Down

0 comments on commit 717b594

Please sign in to comment.