Skip to content

Commit

Permalink
iommu/amd: Optimize iommu_unmap_page for new fetch_pte interface
Browse files Browse the repository at this point in the history
Now that fetch_pte returns the page-size of the pte, this
function can be optimized a lot.

Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Joerg Roedel committed Apr 2, 2015
1 parent 3039ca1 commit 71b390e
Showing 1 changed file with 8 additions and 24 deletions.
32 changes: 8 additions & 24 deletions drivers/iommu/amd_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1428,8 +1428,8 @@ static unsigned long iommu_unmap_page(struct protection_domain *dom,
unsigned long bus_addr,
unsigned long page_size)
{
unsigned long long unmap_size, unmapped;
unsigned long pte_pgsize;
unsigned long long unmapped;
unsigned long unmap_size;
u64 *pte;

BUG_ON(!is_power_of_2(page_size));
Expand All @@ -1438,28 +1438,12 @@ static unsigned long iommu_unmap_page(struct protection_domain *dom,

while (unmapped < page_size) {

pte = fetch_pte(dom, bus_addr, &pte_pgsize);

if (!pte) {
/*
* No PTE for this address
* move forward in 4kb steps
*/
unmap_size = PAGE_SIZE;
} else if (PM_PTE_LEVEL(*pte) == 0) {
/* 4kb PTE found for this address */
unmap_size = PAGE_SIZE;
*pte = 0ULL;
} else {
int count, i;

/* Large PTE found which maps this address */
unmap_size = PTE_PAGE_SIZE(*pte);

/* Only unmap from the first pte in the page */
if ((unmap_size - 1) & bus_addr)
break;
count = PAGE_SIZE_PTE_COUNT(unmap_size);
pte = fetch_pte(dom, bus_addr, &unmap_size);

if (pte) {
int i, count;

count = PAGE_SIZE_PTE_COUNT(unmap_size);
for (i = 0; i < count; i++)
pte[i] = 0ULL;
}
Expand Down

0 comments on commit 71b390e

Please sign in to comment.