Skip to content

Commit

Permalink
staging: comedi: comedi_fops: use kzalloc in comedi_alloc_subdevice_m…
Browse files Browse the repository at this point in the history
…inor()

The hardware_device member of comedi_file_info is not set in this
function. Use kzalloc to make sure this pointer does not contain
invalid data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jan 7, 2013
1 parent a52840a commit 71cf6d3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/staging/comedi/comedi_fops.c
Original file line number Diff line number Diff line change
Expand Up @@ -2376,8 +2376,8 @@ int comedi_alloc_subdevice_minor(struct comedi_device *dev,
struct device *csdev;
unsigned i;

info = kmalloc(sizeof(*info), GFP_KERNEL);
if (info == NULL)
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info)
return -ENOMEM;
info->device = dev;
info->read_subdevice = s;
Expand Down

0 comments on commit 71cf6d3

Please sign in to comment.