Skip to content

Commit

Permalink
sock.c: potential null dereference
Browse files Browse the repository at this point in the history
We test that "prot->rsk_prot" is non-null right before we dereference it
on this line.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Mar 7, 2010
1 parent ea3fb37 commit 72150e9
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/core/sock.c
Original file line number Diff line number Diff line change
Expand Up @@ -2288,7 +2288,8 @@ int proto_register(struct proto *prot, int alloc_slab)
prot->rsk_prot->slab = NULL;
}
out_free_request_sock_slab_name:
kfree(prot->rsk_prot->slab_name);
if (prot->rsk_prot)
kfree(prot->rsk_prot->slab_name);
out_free_sock_slab:
kmem_cache_destroy(prot->slab);
prot->slab = NULL;
Expand Down

0 comments on commit 72150e9

Please sign in to comment.