Skip to content

Commit

Permalink
igbvf: avoid reset storms due to mailbox issues
Browse files Browse the repository at this point in the history
From: Alexander Duyck <alexander.h.duyck@intel.com>

This change makes it so that reset/interrupt storms can be avoided when
there are mailbox issues.  The new behavior is to only allow the device to
trigger mailbox related resets only once every 10 seconds.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Duyck authored and David S. Miller committed Dec 12, 2009
1 parent fef45f4 commit 7227909
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions drivers/net/igbvf/igbvf.h
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ struct igbvf_adapter {
unsigned long led_status;

unsigned int flags;
unsigned long last_reset;
};

struct igbvf_info {
Expand Down
8 changes: 7 additions & 1 deletion drivers/net/igbvf/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1469,6 +1469,8 @@ static void igbvf_reset(struct igbvf_adapter *adapter)
memcpy(netdev->perm_addr, adapter->hw.mac.addr,
netdev->addr_len);
}

adapter->last_reset = jiffies;
}

int igbvf_up(struct igbvf_adapter *adapter)
Expand Down Expand Up @@ -1812,11 +1814,15 @@ static bool igbvf_has_link(struct igbvf_adapter *adapter)
s32 ret_val = E1000_SUCCESS;
bool link_active;

/* If interface is down, stay link down */
if (test_bit(__IGBVF_DOWN, &adapter->state))
return false;

ret_val = hw->mac.ops.check_for_link(hw);
link_active = !hw->mac.get_link_status;

/* if check for link returns error we will need to reset */
if (ret_val)
if (ret_val && time_after(jiffies, adapter->last_reset + (10 * HZ)))
schedule_work(&adapter->reset_task);

return link_active;
Expand Down

0 comments on commit 7227909

Please sign in to comment.