Skip to content

Commit

Permalink
mlx4_en: Fix not deleted napi structures
Browse files Browse the repository at this point in the history
Napi structures are being created each time we open a port, but when
the port is closed the napi structure is only disabled but not removed.
This bug caused hang while removing the driver.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yevgeny Petrilin authored and David S. Miller committed May 18, 2009
1 parent 2513dfb commit 72876a6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/mlx4/en_cq.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,10 @@ void mlx4_en_deactivate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq)

if (cq->is_tx)
del_timer(&cq->timer);
else
else {
napi_disable(&cq->napi);
netif_napi_del(&cq->napi);
}

mlx4_cq_free(mdev->dev, &cq->mcq);
}
Expand Down

0 comments on commit 72876a6

Please sign in to comment.