Skip to content

Commit

Permalink
mac80211: reduce the number of retries for nullfunc probing
Browse files Browse the repository at this point in the history
Since nullfunc frames are transmitted as unicast frames, they're more
reliable than the broadcast probe requests, so we need fewer retries
to figure out whether the AP is really gone.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Felix Fietkau authored and John W. Linville committed Nov 24, 2010
1 parent 4e5ff37 commit 72a8a3e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion net/mac80211/mlme.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "rate.h"
#include "led.h"

#define IEEE80211_MAX_NULLFUNC_TRIES 2
#define IEEE80211_MAX_PROBE_TRIES 5

/*
Expand Down Expand Up @@ -1924,17 +1925,23 @@ void ieee80211_sta_work(struct ieee80211_sub_if_data *sdata)
IEEE80211_STA_CONNECTION_POLL) &&
ifmgd->associated) {
u8 bssid[ETH_ALEN];
int max_tries;

memcpy(bssid, ifmgd->associated->bssid, ETH_ALEN);

if (local->hw.flags & IEEE80211_HW_REPORTS_TX_ACK_STATUS)
max_tries = IEEE80211_MAX_NULLFUNC_TRIES;
else
max_tries = IEEE80211_MAX_PROBE_TRIES;

/* ACK received for nullfunc probing frame */
if (!ifmgd->probe_send_count)
ieee80211_reset_ap_probe(sdata);

else if (time_is_after_jiffies(ifmgd->probe_timeout))
run_again(ifmgd, ifmgd->probe_timeout);

else if (ifmgd->probe_send_count < IEEE80211_MAX_PROBE_TRIES) {
else if (ifmgd->probe_send_count < max_tries) {
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
wiphy_debug(local->hw.wiphy,
"%s: No probe response from AP %pM"
Expand Down

0 comments on commit 72a8a3e

Please sign in to comment.