Skip to content

Commit

Permalink
[CRYPTO] api: Rename crypto_alg_get to crypto_mod_get
Browse files Browse the repository at this point in the history
The functions crypto_alg_get and crypto_alg_put operates on the crypto
modules rather than the algorithms.  Therefore it makes sense to call
them crypto_mod_get and crypto_alg_put respectively.

This is needed because we need to have real algorithm reference counters
for parameterised algorithms as they can be unregistered from below by
when their parameter algorithms are themselves unregistered.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu committed Sep 21, 2006
1 parent eaf4408 commit 72fa491
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions crypto/api.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
LIST_HEAD(crypto_alg_list);
DECLARE_RWSEM(crypto_alg_sem);

static inline int crypto_alg_get(struct crypto_alg *alg)
static inline int crypto_mod_get(struct crypto_alg *alg)
{
return try_module_get(alg->cra_module);
}

static inline void crypto_alg_put(struct crypto_alg *alg)
static inline void crypto_mod_put(struct crypto_alg *alg)
{
module_put(alg->cra_module);
}
Expand All @@ -57,12 +57,12 @@ static struct crypto_alg *crypto_alg_lookup(const char *name)
if (!exact && !(fuzzy && q->cra_priority > best))
continue;

if (unlikely(!crypto_alg_get(q)))
if (unlikely(!crypto_mod_get(q)))
continue;

best = q->cra_priority;
if (alg)
crypto_alg_put(alg);
crypto_mod_put(alg);
alg = q;

if (exact)
Expand Down Expand Up @@ -202,7 +202,7 @@ struct crypto_tfm *crypto_alloc_tfm(const char *name, u32 flags)
kfree(tfm);
tfm = NULL;
out_put:
crypto_alg_put(alg);
crypto_mod_put(alg);
out:
return tfm;
}
Expand All @@ -221,7 +221,7 @@ void crypto_free_tfm(struct crypto_tfm *tfm)
if (alg->cra_exit)
alg->cra_exit(tfm);
crypto_exit_ops(tfm);
crypto_alg_put(alg);
crypto_mod_put(alg);
memset(tfm, 0, size);
kfree(tfm);
}
Expand Down Expand Up @@ -305,7 +305,7 @@ int crypto_alg_available(const char *name, u32 flags)
struct crypto_alg *alg = crypto_alg_mod_lookup(name);

if (alg) {
crypto_alg_put(alg);
crypto_mod_put(alg);
ret = 1;
}

Expand Down

0 comments on commit 72fa491

Please sign in to comment.