Skip to content

Commit

Permalink
staging: gdm72xx: use list_move instead of list_del/list_add
Browse files Browse the repository at this point in the history
Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Wei Yongjun authored and Greg Kroah-Hartman committed Sep 6, 2012
1 parent 84bda90 commit 73295fe
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/staging/gdm72xx/gdm_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,7 @@ static struct usb_rx *get_rx_struct(struct rx_cxt *rx)
/* Before this function is called, spin lock should be locked. */
static void put_rx_struct(struct rx_cxt *rx, struct usb_rx *r)
{
list_del(&r->list);
list_add(&r->list, &rx->free_list);
list_move(&r->list, &rx->free_list);
}

static int init_usb(struct usbwm_dev *udev)
Expand Down

0 comments on commit 73295fe

Please sign in to comment.