Skip to content

Commit

Permalink
r8169: fix infinite loop during hotplug
Browse files Browse the repository at this point in the history
Bug reported for PCMCIA.

Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
  • Loading branch information
Arnaud Patard authored and Francois Romieu committed Oct 12, 2006
1 parent 73f5e28 commit 733b736
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -2702,6 +2702,7 @@ static void rtl8169_down(struct net_device *dev)
struct rtl8169_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp->mmio_addr;
unsigned int poll_locked = 0;
unsigned int intrmask;

rtl8169_delete_timer(dev);

Expand Down Expand Up @@ -2740,8 +2741,11 @@ static void rtl8169_down(struct net_device *dev)
* 2) dev->change_mtu
* -> rtl8169_poll can not be issued again and re-enable the
* interruptions. Let's simply issue the IRQ down sequence again.
*
* No loop if hotpluged or major error (0xffff).
*/
if (RTL_R16(IntrMask))
intrmask = RTL_R16(IntrMask);
if (intrmask && (intrmask != 0xffff))
goto core_down;

rtl8169_tx_clear(tp);
Expand Down

0 comments on commit 733b736

Please sign in to comment.