Skip to content

Commit

Permalink
V4L/DVB: IR: only initially registers protocol that matches loaded ke…
Browse files Browse the repository at this point in the history
…ymap

Rather than registering all IR protocol decoders as enabled when bringing
up a new device, only enable the IR protocol decoder that matches the
keymap being loaded. Additional decoders can be enabled on the fly by
those that need to, either by twiddling sysfs bits or by using the
ir-keytable util from v4l-utils.

Functional testing done with the mceusb driver, and it behaves as expected,
only the rc6 decoder is enabled, keys are all handled properly, etc.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jarod Wilson authored and Mauro Carvalho Chehab committed Aug 2, 2010
1 parent c228426 commit 7366646
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
4 changes: 3 additions & 1 deletion drivers/media/IR/ir-jvc-decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ static int ir_jvc_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
struct decoder_data *data;
u64 ir_type = ir_dev->rc_tab.ir_type;
int rc;

rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
Expand All @@ -266,7 +267,8 @@ static int ir_jvc_register(struct input_dev *input_dev)
}

data->ir_dev = ir_dev;
data->enabled = 1;
if (ir_type == IR_TYPE_JVC || ir_type == IR_TYPE_UNKNOWN)
data->enabled = 1;

spin_lock(&decoder_lock);
list_add_tail(&data->list, &decoder_list);
Expand Down
4 changes: 3 additions & 1 deletion drivers/media/IR/ir-nec-decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ static int ir_nec_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
struct decoder_data *data;
u64 ir_type = ir_dev->rc_tab.ir_type;
int rc;

rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
Expand All @@ -273,7 +274,8 @@ static int ir_nec_register(struct input_dev *input_dev)
}

data->ir_dev = ir_dev;
data->enabled = 1;
if (ir_type == IR_TYPE_NEC || ir_type == IR_TYPE_UNKNOWN)
data->enabled = 1;

spin_lock(&decoder_lock);
list_add_tail(&data->list, &decoder_list);
Expand Down
4 changes: 3 additions & 1 deletion drivers/media/IR/ir-rc5-decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ static int ir_rc5_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
struct decoder_data *data;
u64 ir_type = ir_dev->rc_tab.ir_type;
int rc;

rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
Expand All @@ -269,7 +270,8 @@ static int ir_rc5_register(struct input_dev *input_dev)
}

data->ir_dev = ir_dev;
data->enabled = 1;
if (ir_type == IR_TYPE_RC5 || ir_type == IR_TYPE_UNKNOWN)
data->enabled = 1;

spin_lock(&decoder_lock);
list_add_tail(&data->list, &decoder_list);
Expand Down
4 changes: 3 additions & 1 deletion drivers/media/IR/ir-rc6-decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ static int ir_rc6_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
struct decoder_data *data;
u64 ir_type = ir_dev->rc_tab.ir_type;
int rc;

rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
Expand All @@ -365,7 +366,8 @@ static int ir_rc6_register(struct input_dev *input_dev)
}

data->ir_dev = ir_dev;
data->enabled = 1;
if (ir_type == IR_TYPE_RC6 || ir_type == IR_TYPE_UNKNOWN)
data->enabled = 1;

spin_lock(&decoder_lock);
list_add_tail(&data->list, &decoder_list);
Expand Down
4 changes: 3 additions & 1 deletion drivers/media/IR/ir-sony-decoder.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ static int ir_sony_register(struct input_dev *input_dev)
{
struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
struct decoder_data *data;
u64 ir_type = ir_dev->rc_tab.ir_type;
int rc;

rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
Expand All @@ -258,7 +259,8 @@ static int ir_sony_register(struct input_dev *input_dev)
}

data->ir_dev = ir_dev;
data->enabled = 1;
if (ir_type == IR_TYPE_SONY || ir_type == IR_TYPE_UNKNOWN)
data->enabled = 1;

spin_lock(&decoder_lock);
list_add_tail(&data->list, &decoder_list);
Expand Down

0 comments on commit 7366646

Please sign in to comment.