Skip to content

Commit

Permalink
iwlwifi: move firmware_name to iwl_nic
Browse files Browse the repository at this point in the history
Delete firmware_name from iwl_priv and use iwl_nic instead.

Signed-off-by: Don Fry <donald.h.fry@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
  • Loading branch information
Don Fry authored and Wey-Yi Guy committed Feb 17, 2012
1 parent f6fd51d commit 737805f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
3 changes: 0 additions & 3 deletions drivers/net/wireless/iwlwifi/iwl-dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -787,9 +787,6 @@ struct iwl_priv {
/* EEPROM MAC addresses */
struct mac_address addresses[2];

/* uCode images, save to reload in case of failure */
char firmware_name[25];

struct iwl_rxon_context contexts[NUM_IWL_RXON_CTX];

__le16 switch_channel;
Expand Down
10 changes: 5 additions & 5 deletions drivers/net/wireless/iwlwifi/iwl-ucode.c
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,14 @@ int __must_check iwl_request_firmware(struct iwl_priv *priv, bool first)
return -ENOENT;
}

sprintf(priv->firmware_name, "%s%s%s", name_pre, tag, ".ucode");
sprintf(nic->firmware_name, "%s%s%s", name_pre, tag, ".ucode");

IWL_DEBUG_INFO(priv, "attempting to load firmware %s'%s'\n",
(nic->fw_index == UCODE_EXPERIMENTAL_INDEX)
? "EXPERIMENTAL " : "",
priv->firmware_name);
nic->firmware_name);

return request_firmware_nowait(THIS_MODULE, 1, priv->firmware_name,
return request_firmware_nowait(THIS_MODULE, 1, nic->firmware_name,
trans(priv)->dev,
GFP_KERNEL, priv, iwl_ucode_callback);
}
Expand Down Expand Up @@ -1036,12 +1036,12 @@ static void iwl_ucode_callback(const struct firmware *ucode_raw, void *context)
if (nic->fw_index <= api_ok)
IWL_ERR(priv,
"request for firmware file '%s' failed.\n",
priv->firmware_name);
nic->firmware_name);
goto try_again;
}

IWL_DEBUG_INFO(priv, "Loaded firmware file '%s' (%zd bytes).\n",
priv->firmware_name, ucode_raw->size);
nic->firmware_name, ucode_raw->size);

/* Make sure that we got at least the API version number */
if (ucode_raw->size < 4) {
Expand Down

0 comments on commit 737805f

Please sign in to comment.