Skip to content

Commit

Permalink
[PATCH] nfsd4: fix setclientid unlock of unlocked state lock
Browse files Browse the repository at this point in the history
We could try to unlock the state lock here without having first locked it.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Neil Brown authored and Linus Torvalds committed Sep 13, 2005
1 parent b59e3c0 commit 73aea4e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -678,13 +678,12 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_setclientid *setclid)
int status;
char dname[HEXDIR_LEN];

status = nfserr_inval;
if (!check_name(clname))
goto out;
return nfserr_inval;

status = nfs4_make_rec_clidname(dname, &clname);
if (status)
goto out;
return status;

/*
* XXX The Duplicate Request Cache (DRC) has been checked (??)
Expand Down

0 comments on commit 73aea4e

Please sign in to comment.