Skip to content

Commit

Permalink
drm/nouveau: don't execute INIT_GPIO unless we're really running the …
Browse files Browse the repository at this point in the history
…table

This resulted in accidently switching off the eDP panel on certain laptops
since the default state in the GPIO table was off.

Fixes rh#582621

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
  • Loading branch information
Ben Skeggs committed May 28, 2010
1 parent f50c0b9 commit 73db4be
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/gpu/drm/nouveau/nouveau_bios.c
Original file line number Diff line number Diff line change
Expand Up @@ -2807,7 +2807,10 @@ init_gpio(struct nvbios *bios, uint16_t offset, struct init_exec *iexec)

BIOSLOG(bios, "0x%04X: Entry: 0x%08X\n", offset, gpio->entry);

nv50_gpio_set(bios->dev, gpio->tag, gpio->state_default);
BIOSLOG(bios, "0x%04X: set gpio 0x%02x, state %d\n",
offset, gpio->tag, gpio->state_default);
if (bios->execute)
nv50_gpio_set(bios->dev, gpio->tag, gpio->state_default);

/* The NVIDIA binary driver doesn't appear to actually do
* any of this, my VBIOS does however.
Expand Down

0 comments on commit 73db4be

Please sign in to comment.