Skip to content

Commit

Permalink
checkpatch: improve type matcher debug
Browse files Browse the repository at this point in the history
Improve type matcher debug so we can see what it does match.  As part
of this move us to to using the common debug framework.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andy Whitcroft authored and Linus Torvalds committed Jul 24, 2008
1 parent 389a2fe commit 7429c69
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions scripts/checkpatch.pl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
my $tree = 1;
my $chk_signoff = 1;
my $chk_patch = 1;
my $tst_type = 0;
my $tst_only;
my $emacs = 0;
my $terse = 0;
Expand All @@ -44,7 +43,6 @@
'summary-file!' => \$summary_file,

'debug=s' => \%debug,
'test-type!' => \$tst_type,
'test-only=s' => \$tst_only,
) or exit;

Expand All @@ -67,6 +65,7 @@

my $dbg_values = 0;
my $dbg_possible = 0;
my $dbg_type = 0;
for my $key (keys %debug) {
eval "\${dbg_$key} = '$debug{$key}';"
}
Expand Down Expand Up @@ -1307,8 +1306,12 @@ sub process {
if ($line=~/^[^\+]/) {next;}

# TEST: allow direct testing of the type matcher.
if ($tst_type && $line =~ /^.$Declare$/) {
ERROR("TEST: is type $Declare\n" . $herecurr);
if ($dbg_type) {
if ($line =~ /^.\s*$Declare\s*$/) {
ERROR("TEST: is type\n" . $herecurr);
} elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
ERROR("TEST: is not type ($1 is)\n". $herecurr);
}
next;
}

Expand Down

0 comments on commit 7429c69

Please sign in to comment.