Skip to content

Commit

Permalink
ethoc: enable interrupts after napi_complete
Browse files Browse the repository at this point in the history
Occasionally, it seems that some race is causing the interrupts to not be
reenabled otherwise with the end result that networking just stops working.
Enabling interrupts after calling napi_complete is more in line with what
other drivers do.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Adam Edvardsson authored and David S. Miller committed Nov 28, 2010
1 parent eac0d3f commit 7438a54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethoc.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,8 +569,8 @@ static int ethoc_poll(struct napi_struct *napi, int budget)

work_done = ethoc_rx(priv->netdev, budget);
if (work_done < budget) {
ethoc_enable_irq(priv, INT_MASK_RX);
napi_complete(napi);
ethoc_enable_irq(priv, INT_MASK_RX);
}

return work_done;
Expand Down

0 comments on commit 7438a54

Please sign in to comment.