Skip to content

Commit

Permalink
ACPI: fix checkpatch.pl complaints in scan.c
Browse files Browse the repository at this point in the history
http://bugzilla.kernel.org/show_bug.cgi?id=9772

Signed-off-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
  • Loading branch information
Alok N Kataria authored and Andi Kleen committed Jul 16, 2008
1 parent 20b9373 commit 74523c9
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#include <linux/init.h>
#include <linux/kernel.h>
#include <linux/acpi.h>
#include <asm/signal.h>
#include <linux/signal.h>
#include <linux/kthread.h>

#include <acpi/acpi_drivers.h>
#include <acpi/acinterp.h> /* for acpi_ex_eisa_id_to_string() */
Expand Down Expand Up @@ -154,6 +155,7 @@ acpi_eject_store(struct device *d, struct device_attribute *attr,
acpi_status status;
acpi_object_type type = 0;
struct acpi_device *acpi_device = to_acpi_device(d);
struct task_struct *task;

if ((!count) || (buf[0] != '1')) {
return -EINVAL;
Expand All @@ -171,9 +173,11 @@ acpi_eject_store(struct device *d, struct device_attribute *attr,
}

/* remove the device in another thread to fix the deadlock issue */
ret = kernel_thread(acpi_bus_hot_remove_device,
acpi_device->handle, SIGCHLD);
err:
task = kthread_run(acpi_bus_hot_remove_device,
acpi_device->handle, "acpi_hot_remove_device");
if (IS_ERR(task))
ret = PTR_ERR(task);
err:
return ret;
}

Expand Down

0 comments on commit 74523c9

Please sign in to comment.