Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 158252
b: refs/heads/master
c: 9f86669
h: refs/heads/master
v: v3
  • Loading branch information
Brice Goglin authored and Ingo Molnar committed Aug 10, 2009
1 parent 9ff53bb commit 747abf6
Show file tree
Hide file tree
Showing 4 changed files with 74 additions and 4 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8d51327090ac025d7f4ce6c059786b5e93513321
refs/heads/master: 9f8666971185b86615a074bcac67c90fdf8af8bc
11 changes: 10 additions & 1 deletion trunk/tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ static int show_nr_samples;
static int show_threads;
static struct perf_read_values show_threads_values;

static char default_pretty_printing_style[] = "normal";
static char *pretty_printing_style = default_pretty_printing_style;

static unsigned long page_size;
static unsigned long mmap_window = 32;

Expand Down Expand Up @@ -1401,6 +1404,9 @@ static size_t output__fprintf(FILE *fp, u64 total_samples)
size_t ret = 0;
unsigned int width;
char *col_width = col_width_list_str;
int raw_printing_style;

raw_printing_style = !strcmp(pretty_printing_style, "raw");

init_rem_hits();

Expand Down Expand Up @@ -1478,7 +1484,8 @@ static size_t output__fprintf(FILE *fp, u64 total_samples)
free(rem_sq_bracket);

if (show_threads)
perf_read_values_display(fp, &show_threads_values);
perf_read_values_display(fp, &show_threads_values,
raw_printing_style);

return ret;
}
Expand Down Expand Up @@ -2091,6 +2098,8 @@ static const struct option options[] = {
"Show a column with the number of samples"),
OPT_BOOLEAN('T', "threads", &show_threads,
"Show per-thread event counters"),
OPT_STRING(0, "pretty", &pretty_printing_style, "key",
"pretty printing style key: normal raw"),
OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
"sort by key(s): pid, comm, dso, symbol, parent"),
OPT_BOOLEAN('P', "full-paths", &full_paths,
Expand Down
62 changes: 61 additions & 1 deletion trunk/tools/perf/util/values.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ void perf_read_values_add_value(struct perf_read_values *values,
values->value[tindex][cindex] = value;
}

void perf_read_values_display(FILE *fp, struct perf_read_values *values)
static void perf_read_values__display_pretty(FILE *fp,
struct perf_read_values *values)
{
int i, j;
int pidwidth, tidwidth;
Expand Down Expand Up @@ -169,3 +170,62 @@ void perf_read_values_display(FILE *fp, struct perf_read_values *values)
fprintf(fp, "\n");
}
}

static void perf_read_values__display_raw(FILE *fp,
struct perf_read_values *values)
{
int width, pidwidth, tidwidth, namewidth, rawwidth, countwidth;
int i, j;

tidwidth = 3; /* TID */
pidwidth = 3; /* PID */
namewidth = 4; /* "Name" */
rawwidth = 3; /* "Raw" */
countwidth = 5; /* "Count" */

for (i = 0; i < values->threads; i++) {
width = snprintf(NULL, 0, "%d", values->pid[i]);
if (width > pidwidth)
pidwidth = width;
width = snprintf(NULL, 0, "%d", values->tid[i]);
if (width > tidwidth)
tidwidth = width;
}
for (j = 0; j < values->counters; j++) {
width = strlen(values->countername[j]);
if (width > namewidth)
namewidth = width;
width = snprintf(NULL, 0, "%llx", values->counterrawid[j]);
if (width > rawwidth)
rawwidth = width;
}
for (i = 0; i < values->threads; i++) {
for (j = 0; j < values->counters; j++) {
width = snprintf(NULL, 0, "%Lu", values->value[i][j]);
if (width > countwidth)
countwidth = width;
}
}

fprintf(fp, "# %*s %*s %*s %*s %*s\n",
pidwidth, "PID", tidwidth, "TID",
namewidth, "Name", rawwidth, "Raw",
countwidth, "Count");
for (i = 0; i < values->threads; i++)
for (j = 0; j < values->counters; j++)
fprintf(fp, " %*d %*d %*s %*llx %*Lu\n",
pidwidth, values->pid[i],
tidwidth, values->tid[i],
namewidth, values->countername[j],
rawwidth, values->counterrawid[j],
countwidth, values->value[i][j]);
}

void perf_read_values_display(FILE *fp, struct perf_read_values *values,
int raw)
{
if (raw)
perf_read_values__display_raw(fp, values);
else
perf_read_values__display_pretty(fp, values);
}
3 changes: 2 additions & 1 deletion trunk/tools/perf/util/values.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ void perf_read_values_add_value(struct perf_read_values *values,
u32 pid, u32 tid,
u64 rawid, char *name, u64 value);

void perf_read_values_display(FILE *fp, struct perf_read_values *values);
void perf_read_values_display(FILE *fp, struct perf_read_values *values,
int raw);

#endif /* _PERF_VALUES_H */

0 comments on commit 747abf6

Please sign in to comment.