---

yaml
---
r: 261407
b: refs/heads/master
c: 71c6c4c
h: refs/heads/master
i:
  261405: a189e4e
  261403: 3cc5062
  261399: 235d8ef
  261391: 208f7ca
  261375: bfd474e
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: e64025850d11afd0a9ad14d40310bec7ff0f4847
+refs/heads/master: 71c6c4c918696625164ffdac4ece9f83bd4a6694

trunk/drivers/media/video/v4l2-ctrls.c

@@ -1411,26 +1411,21 @@ int v4l2_ctrl_handler_setup(struct v4l2_ctrl_handler *hdl)
 		int i;
 
 		/* Skip if this control was already handled by a cluster. */
-		if (ctrl->done)
+		/* Skip button controls and read-only controls. */
+		if (ctrl->done || ctrl->type == V4L2_CTRL_TYPE_BUTTON ||
+		    (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY))
 			continue;
 
 		for (i = 0; i < master->ncontrols; i++) {
 			if (master->cluster[i]) {
 				cur_to_new(master->cluster[i]);
 				master->cluster[i]->is_new = 1;
+				master->cluster[i]->done = true;
 			}
 		}
-
-		/* Skip button controls and read-only controls. */
-		if (ctrl->type == V4L2_CTRL_TYPE_BUTTON ||
-		    (ctrl->flags & V4L2_CTRL_FLAG_READ_ONLY))
-			continue;
 		ret = call_op(master, s_ctrl);
 		if (ret)
 			break;
-		for (i = 0; i < master->ncontrols; i++)
-			if (master->cluster[i])
-				master->cluster[i]->done = true;
 	}
 	mutex_unlock(&hdl->lock);
 	return ret;