Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 96045
b: refs/heads/master
c: cb4ad1f
h: refs/heads/master
i:
  96043: 548d8bd
v: v3
  • Loading branch information
Miao Xie authored and Ingo Molnar committed May 5, 2008
1 parent 86f2596 commit 74921d8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 712555ee4f873515612f89554ad1a3fda5fa887e
refs/heads/master: cb4ad1ffc7c0d8ea7dc8cd8ba303d83551716d46
17 changes: 11 additions & 6 deletions trunk/kernel/sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,13 @@ static DEFINE_SPINLOCK(task_group_lock);
# define INIT_TASK_GROUP_LOAD NICE_0_LOAD
#endif

/*
* A weight of 0, 1 or ULONG_MAX can cause arithmetics problems.
* (The default weight is 1024 - so there's no practical
* limitation from this.)
*/
#define MIN_SHARES 2
#define MAX_SHARES (ULONG_MAX - 1)

static int init_task_group_load = INIT_TASK_GROUP_LOAD;
#endif
Expand Down Expand Up @@ -1804,6 +1810,8 @@ __update_group_shares_cpu(struct task_group *tg, struct sched_domain *sd,

if (shares < MIN_SHARES)
shares = MIN_SHARES;
else if (shares > MAX_SHARES)
shares = MAX_SHARES;

__set_se_shares(tg->se[tcpu], shares);
}
Expand Down Expand Up @@ -8785,13 +8793,10 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares)
if (!tg->se[0])
return -EINVAL;

/*
* A weight of 0 or 1 can cause arithmetics problems.
* (The default weight is 1024 - so there's no practical
* limitation from this.)
*/
if (shares < MIN_SHARES)
shares = MIN_SHARES;
else if (shares > MAX_SHARES)
shares = MAX_SHARES;

mutex_lock(&shares_mutex);
if (tg->shares == shares)
Expand All @@ -8816,7 +8821,7 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares)
* force a rebalance
*/
cfs_rq_set_shares(tg->cfs_rq[i], 0);
set_se_shares(tg->se[i], shares/nr_cpu_ids);
set_se_shares(tg->se[i], shares);
}

/*
Expand Down

0 comments on commit 74921d8

Please sign in to comment.