Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 206567
b: refs/heads/master
c: cc3202f
h: refs/heads/master
i:
  206565: e4141ae
  206563: 24544b2
  206559: 2a01e73
v: v3
  • Loading branch information
Vladimir Zapolskiy authored and Mark Brown committed Jun 25, 2010
1 parent f98d9fe commit 7499dbb
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5898dd9ebd158d9fd3c197fc640d0c104bef39a5
refs/heads/master: cc3202f5da3c81a99c5f3a605df527da7a77eed3
12 changes: 12 additions & 0 deletions trunk/include/sound/uda134x.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@ struct uda134x_platform_data {
struct l3_pins l3;
void (*power) (int);
int model;
/*
ALSA SOC usually puts the device in standby mode when it's not used
for sometime. If you unset is_powered_on_standby the driver will
turn off the ADC/DAC when this callback is invoked and turn it back
on when needed. Unfortunately this will result in a very light bump
(it can be audible only with good earphones). If this bothers you
set is_powered_on_standby, you will have slightly higher power
consumption. Please note that sending the L3 command for ADC is
enough to make the bump, so it doesn't make difference if you
completely take off power from the codec.
*/
int is_powered_on_standby;
#define UDA134X_UDA1340 1
#define UDA134X_UDA1341 2
#define UDA134X_UDA1344 3
Expand Down
21 changes: 5 additions & 16 deletions trunk/sound/soc/codecs/uda134x.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,6 @@
#include "uda134x.h"


#define POWER_OFF_ON_STANDBY 1
/*
ALSA SOC usually puts the device in standby mode when it's not used
for sometime. If you define POWER_OFF_ON_STANDBY the driver will
turn off the ADC/DAC when this callback is invoked and turn it back
on when needed. Unfortunately this will result in a very light bump
(it can be audible only with good earphones). If this bothers you
just comment this line, you will have slightly higher power
consumption . Please note that sending the L3 command for ADC is
enough to make the bump, so it doesn't make difference if you
completely take off power from the codec.
*/

#define UDA134X_RATES SNDRV_PCM_RATE_8000_48000
#define UDA134X_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE | \
SNDRV_PCM_FMTBIT_S18_3LE | SNDRV_PCM_FMTBIT_S20_3LE)
Expand Down Expand Up @@ -531,9 +518,11 @@ static int uda134x_soc_probe(struct platform_device *pdev)
codec->num_dai = 1;
codec->read = uda134x_read_reg_cache;
codec->write = uda134x_write;
#ifdef POWER_OFF_ON_STANDBY
codec->set_bias_level = uda134x_set_bias_level;
#endif

if (!pd->is_powered_on_standby) {
codec->set_bias_level = uda134x_set_bias_level;
}

INIT_LIST_HEAD(&codec->dapm_widgets);
INIT_LIST_HEAD(&codec->dapm_paths);

Expand Down

0 comments on commit 7499dbb

Please sign in to comment.