Skip to content

Commit

Permalink
ext2: constify xattr_handler
Browse files Browse the repository at this point in the history
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Stephen Hemminger authored and Al Viro committed May 21, 2010
1 parent f01cbd3 commit 749c72e
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
4 changes: 2 additions & 2 deletions fs/ext2/acl.c
Original file line number Diff line number Diff line change
Expand Up @@ -420,15 +420,15 @@ ext2_xattr_set_acl(struct dentry *dentry, const char *name, const void *value,
return error;
}

struct xattr_handler ext2_xattr_acl_access_handler = {
const struct xattr_handler ext2_xattr_acl_access_handler = {
.prefix = POSIX_ACL_XATTR_ACCESS,
.flags = ACL_TYPE_ACCESS,
.list = ext2_xattr_list_acl_access,
.get = ext2_xattr_get_acl,
.set = ext2_xattr_set_acl,
};

struct xattr_handler ext2_xattr_acl_default_handler = {
const struct xattr_handler ext2_xattr_acl_default_handler = {
.prefix = POSIX_ACL_XATTR_DEFAULT,
.flags = ACL_TYPE_DEFAULT,
.list = ext2_xattr_list_acl_default,
Expand Down
10 changes: 5 additions & 5 deletions fs/ext2/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ static void ext2_xattr_rehash(struct ext2_xattr_header *,

static struct mb_cache *ext2_xattr_cache;

static struct xattr_handler *ext2_xattr_handler_map[] = {
static const struct xattr_handler *ext2_xattr_handler_map[] = {
[EXT2_XATTR_INDEX_USER] = &ext2_xattr_user_handler,
#ifdef CONFIG_EXT2_FS_POSIX_ACL
[EXT2_XATTR_INDEX_POSIX_ACL_ACCESS] = &ext2_xattr_acl_access_handler,
Expand All @@ -113,7 +113,7 @@ static struct xattr_handler *ext2_xattr_handler_map[] = {
#endif
};

struct xattr_handler *ext2_xattr_handlers[] = {
const struct xattr_handler *ext2_xattr_handlers[] = {
&ext2_xattr_user_handler,
&ext2_xattr_trusted_handler,
#ifdef CONFIG_EXT2_FS_POSIX_ACL
Expand All @@ -126,10 +126,10 @@ struct xattr_handler *ext2_xattr_handlers[] = {
NULL
};

static inline struct xattr_handler *
static inline const struct xattr_handler *
ext2_xattr_handler(int name_index)
{
struct xattr_handler *handler = NULL;
const struct xattr_handler *handler = NULL;

if (name_index > 0 && name_index < ARRAY_SIZE(ext2_xattr_handler_map))
handler = ext2_xattr_handler_map[name_index];
Expand Down Expand Up @@ -298,7 +298,7 @@ bad_block: ext2_error(inode->i_sb, "ext2_xattr_list",
/* list the attribute names */
for (entry = FIRST_ENTRY(bh); !IS_LAST_ENTRY(entry);
entry = EXT2_XATTR_NEXT(entry)) {
struct xattr_handler *handler =
const struct xattr_handler *handler =
ext2_xattr_handler(entry->e_name_index);

if (handler) {
Expand Down
12 changes: 6 additions & 6 deletions fs/ext2/xattr.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ struct ext2_xattr_entry {

# ifdef CONFIG_EXT2_FS_XATTR

extern struct xattr_handler ext2_xattr_user_handler;
extern struct xattr_handler ext2_xattr_trusted_handler;
extern struct xattr_handler ext2_xattr_acl_access_handler;
extern struct xattr_handler ext2_xattr_acl_default_handler;
extern struct xattr_handler ext2_xattr_security_handler;
extern const struct xattr_handler ext2_xattr_user_handler;
extern const struct xattr_handler ext2_xattr_trusted_handler;
extern const struct xattr_handler ext2_xattr_acl_access_handler;
extern const struct xattr_handler ext2_xattr_acl_default_handler;
extern const struct xattr_handler ext2_xattr_security_handler;

extern ssize_t ext2_listxattr(struct dentry *, char *, size_t);

Expand All @@ -72,7 +72,7 @@ extern void ext2_xattr_put_super(struct super_block *);
extern int init_ext2_xattr(void);
extern void exit_ext2_xattr(void);

extern struct xattr_handler *ext2_xattr_handlers[];
extern const struct xattr_handler *ext2_xattr_handlers[];

# else /* CONFIG_EXT2_FS_XATTR */

Expand Down
2 changes: 1 addition & 1 deletion fs/ext2/xattr_security.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ ext2_init_security(struct inode *inode, struct inode *dir)
return err;
}

struct xattr_handler ext2_xattr_security_handler = {
const struct xattr_handler ext2_xattr_security_handler = {
.prefix = XATTR_SECURITY_PREFIX,
.list = ext2_xattr_security_list,
.get = ext2_xattr_security_get,
Expand Down
2 changes: 1 addition & 1 deletion fs/ext2/xattr_trusted.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ ext2_xattr_trusted_set(struct dentry *dentry, const char *name,
value, size, flags);
}

struct xattr_handler ext2_xattr_trusted_handler = {
const struct xattr_handler ext2_xattr_trusted_handler = {
.prefix = XATTR_TRUSTED_PREFIX,
.list = ext2_xattr_trusted_list,
.get = ext2_xattr_trusted_get,
Expand Down
2 changes: 1 addition & 1 deletion fs/ext2/xattr_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ ext2_xattr_user_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}

struct xattr_handler ext2_xattr_user_handler = {
const struct xattr_handler ext2_xattr_user_handler = {
.prefix = XATTR_USER_PREFIX,
.list = ext2_xattr_user_list,
.get = ext2_xattr_user_get,
Expand Down

0 comments on commit 749c72e

Please sign in to comment.