Skip to content

Commit

Permalink
regulator: max77686: Fix checkpatch warnings
Browse files Browse the repository at this point in the history
Fix below checkpatch warnings:

$ scripts/checkpatch.pl -f drivers/regulator/max77686.c
ERROR: return is not a function, parentheses are not required
+       return (DIV_ROUND_UP(rdev->desc->uV_step

WARNING: line over 80 characters
+       .ops            = &max77686_buck_dvs_ops,                               \

total: 1 errors, 1 warnings, 339 lines checked

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Axel Lin authored and Mark Brown committed Jun 4, 2012
1 parent 0d03273 commit 74adfee
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/regulator/max77686.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,18 @@ static int max77686_set_dvs_voltage_time_sel(struct regulator_dev *rdev,
{
struct max77686_data *max77686 = rdev_get_drvdata(rdev);
int ramp_rate[] = {13, 27, 55, 100};
return (DIV_ROUND_UP(rdev->desc->uV_step
* abs(new_selector - old_selector),
ramp_rate[max77686->ramp_delay]));

return DIV_ROUND_UP(rdev->desc->uV_step *
abs(new_selector - old_selector),
ramp_rate[max77686->ramp_delay]);
}

static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
unsigned int old_selector, unsigned int new_selector)
{
/* Unconditionally 100 mV/us */
return (DIV_ROUND_UP(rdev->desc->uV_step
* abs(new_selector - old_selector), 100));
return DIV_ROUND_UP(rdev->desc->uV_step *
abs(new_selector - old_selector), 100);
}

static struct regulator_ops max77686_ops = {
Expand Down Expand Up @@ -171,7 +172,7 @@ static struct regulator_ops max77686_buck_dvs_ops = {
#define regulator_desc_buck_dvs(num) { \
.name = "BUCK"#num, \
.id = MAX77686_BUCK##num, \
.ops = &max77686_buck_dvs_ops, \
.ops = &max77686_buck_dvs_ops, \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
.min_uV = MAX77686_DVS_MINUV, \
Expand Down

0 comments on commit 74adfee

Please sign in to comment.