Skip to content

Commit

Permalink
Staging: vme: Add syncronize interrupts before removing callback
Browse files Browse the repository at this point in the history
As identified by Jiri, there is no syncronisation before callback is removed.

Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Martyn Welch authored and Greg Kroah-Hartman committed Sep 15, 2009
1 parent 51a569f commit 7515502
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions drivers/staging/vme/bridges/vme_tsi148.c
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,7 @@ int tsi148_request_irq(int level, int statid,
void tsi148_free_irq(int level, int statid)
{
u32 tmp;
struct pci_dev *pdev;

/* Get semaphore */
down(&(vme_irq));
Expand All @@ -495,6 +496,10 @@ void tsi148_free_irq(int level, int statid)
tmp = ioread32be(tsi148_bridge->base + TSI148_LCSR_INTEO);
tmp &= ~TSI148_LCSR_INTEO_IRQEO[level - 1];
iowrite32be(tmp, tsi148_bridge->base + TSI148_LCSR_INTEO);

pdev = container_of(tsi148_bridge->parent, struct pci_dev, dev);

synchronize_irq(pdev->irq);
}

tsi148_bridge->irq[level - 1].callback[statid].func = NULL;
Expand Down

0 comments on commit 7515502

Please sign in to comment.