Skip to content

Commit

Permalink
[PATCH] hp100: fix conditional compilation mess
Browse files Browse the repository at this point in the history
The previous hp100 changeset attempted to kill warnings, but was only
tested on !CONFIG_ISA platforms.  The correct conditional compilation
setup involves tested CONFIG_ISA rather than just MODULE.

Fixes link on CONFIG_ISA platforms (i386) in current -git.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jeff Garzik authored and Linus Torvalds committed Oct 3, 2006
1 parent 0e4a523 commit 7525d4b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/net/Space.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ static struct devprobe2 mca_probes[] __initdata = {
* look for EISA/PCI/MCA cards in addition to ISA cards).
*/
static struct devprobe2 isa_probes[] __initdata = {
#ifdef CONFIG_HP100 /* ISA, EISA & PCI */
#if defined(CONFIG_HP100) && defined(CONFIG_ISA) /* ISA, EISA */
{hp100_probe, 0},
#endif
#ifdef CONFIG_3C515
Expand Down
8 changes: 5 additions & 3 deletions drivers/net/hp100.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ struct hp100_private {
/*
* variables
*/
#ifndef MODULE
#ifdef CONFIG_ISA
static const char *hp100_isa_tbl[] = {
"HWPF150", /* HP J2573 rev A */
"HWP1950", /* HP J2573 */
Expand Down Expand Up @@ -335,7 +335,7 @@ static __devinit const char *hp100_read_id(int ioaddr)
return str;
}

#ifndef MODULE
#ifdef CONFIG_ISA
static __init int hp100_isa_probe1(struct net_device *dev, int ioaddr)
{
const char *sig;
Expand Down Expand Up @@ -393,7 +393,9 @@ static int __init hp100_isa_probe(struct net_device *dev, int addr)
}
return err;
}
#endif /* CONFIG_ISA */

#if !defined(MODULE) && defined(CONFIG_ISA)
struct net_device * __init hp100_probe(int unit)
{
struct net_device *dev = alloc_etherdev(sizeof(struct hp100_private));
Expand Down Expand Up @@ -423,7 +425,7 @@ struct net_device * __init hp100_probe(int unit)
free_netdev(dev);
return ERR_PTR(err);
}
#endif
#endif /* !MODULE && CONFIG_ISA */

static int __devinit hp100_probe1(struct net_device *dev, int ioaddr,
u_char bus, struct pci_dev *pci_dev)
Expand Down

0 comments on commit 7525d4b

Please sign in to comment.