Skip to content

Commit

Permalink
powerpc: Remove superfluous WARN_ON() from dma-noncoherent.c
Browse files Browse the repository at this point in the history
I can't tell why this WARN_ON exists, and there's no comment
explaining it.  Whether the pmd is present or not, pte_alloc_kernel()
seems to handle both cases.

Booting a 440 kernel with 64K PAGE_SIZE triggers the warning, but boot
successfully completes and I see no problems beyond that.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Hollis Blanchard authored and Paul Mackerras committed Nov 19, 2008
1 parent efc3624 commit 7526ff7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion arch/powerpc/lib/dma-noncoherent.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ static int __init dma_alloc_init(void)
ret = -ENOMEM;
break;
}
WARN_ON(!pmd_none(*pmd));

pte = pte_alloc_kernel(pmd, CONSISTENT_BASE);
if (!pte) {
Expand Down

0 comments on commit 7526ff7

Please sign in to comment.