Skip to content

Commit

Permalink
firewire: core: Fix tlabel exhaustion problem
Browse files Browse the repository at this point in the history
fw_core_handle_response() was not properly clearing tlabel_mask. This
was resulting in premature tlabel exhaustion.

Signed-off-by: Peter Hurley <phurley@charter.net>

This fixes an omission in 2.6.31-rc1 commit 1e626fd "firewire: core:
use more outbound tlabels" which prevented to really use 64 instead of
32 transaction labels, as soon as split transactions occurred that had
their AR-resp tasklet run after the AT-req tasklet.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Peter Hurley authored and Stefan Richter committed May 18, 2010
1 parent 7906054 commit 753a897
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/firewire/core-transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,7 @@ void fw_core_handle_response(struct fw_card *card, struct fw_packet *p)
list_for_each_entry(t, &card->transaction_list, link) {
if (t->node_id == source && t->tlabel == tlabel) {
list_del(&t->link);
card->tlabel_mask &= ~(1 << t->tlabel);
card->tlabel_mask &= ~(1ULL << t->tlabel);
break;
}
}
Expand Down

0 comments on commit 753a897

Please sign in to comment.