Skip to content

Commit

Permalink
ahci: kill leftover from enabling NCQ over PMP
Browse files Browse the repository at this point in the history
ahci had problems with NCQ over PMP and NCQ used to be disabled while
PMP was attached.  After fixing the problem, the temporary NCQ
disabling code wasn't removed completely.  Kill the remaining piece.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed Oct 12, 2007
1 parent 9073868 commit 75da6d2
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/ata/ahci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1677,19 +1677,11 @@ static void ahci_pmp_attach(struct ata_port *ap)
static void ahci_pmp_detach(struct ata_port *ap)
{
void __iomem *port_mmio = ahci_port_base(ap);
struct ahci_host_priv *hpriv = ap->host->private_data;
unsigned long flags;
u32 cmd;

cmd = readl(port_mmio + PORT_CMD);
cmd &= ~PORT_CMD_PMP;
writel(cmd, port_mmio + PORT_CMD);

if (hpriv->cap & HOST_CAP_NCQ) {
spin_lock_irqsave(ap->lock, flags);
ap->flags |= ATA_FLAG_NCQ;
spin_unlock_irqrestore(ap->lock, flags);
}
}

static int ahci_pmp_read(struct ata_device *dev, int pmp, int reg, u32 *r_val)
Expand Down

0 comments on commit 75da6d2

Please sign in to comment.