Skip to content

Commit

Permalink
[media] drivers/media/video/davinci/vpbe.c: introduce missing kfree
Browse files Browse the repository at this point in the history
vpbe_dev needs to be freed before leaving the function in an error case.

A simplified version of the semantic match that finds the problem is as
follows: (http://coccinelle.lip6.fr)

// <smpl>
@r exists@
local idexpression x;
statement S;
identifier f1;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
x->f1
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Julia Lawall authored and Mauro Carvalho Chehab committed Jan 6, 2012
1 parent aecf33d commit 75e5ac7
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/media/video/davinci/vpbe.c
Original file line number Diff line number Diff line change
Expand Up @@ -853,8 +853,10 @@ static __devinit int vpbe_probe(struct platform_device *pdev)

if (cfg->outputs->num_modes > 0)
vpbe_dev->current_timings = vpbe_dev->cfg->outputs[0].modes[0];
else
else {
kfree(vpbe_dev);
return -ENODEV;
}

/* set the driver data in platform device */
platform_set_drvdata(pdev, vpbe_dev);
Expand Down

0 comments on commit 75e5ac7

Please sign in to comment.