Skip to content

Commit

Permalink
nfsd4; fix session reference count leak
Browse files Browse the repository at this point in the history
Note the session has to be put() here regardless of what happens to the
client.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
J. Bruce Fields committed Jun 22, 2010
1 parent 68a4b48 commit 76407f7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,6 @@ release_session_client(struct nfsd4_session *session)
} else
renew_client_locked(clp);
spin_unlock(&client_lock);
nfsd4_put_session(session);
}

/* must be called under the client_lock */
Expand Down
1 change: 1 addition & 0 deletions fs/nfsd/nfs4xdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -3325,6 +3325,7 @@ nfs4svc_encode_compoundres(struct svc_rqst *rqstp, __be32 *p, struct nfsd4_compo
}
/* Renew the clientid on success and on replay */
release_session_client(cs->session);
nfsd4_put_session(cs->session);
}
return 1;
}
Expand Down

0 comments on commit 76407f7

Please sign in to comment.