Skip to content

Commit

Permalink
perf top: Remove superfluous name_len field
Browse files Browse the repository at this point in the history
From the sym_entry struct, struct symbol already has this field.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Feb 5, 2011
1 parent fe4b04f commit 764328d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 0 additions & 3 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -787,9 +787,6 @@ static int symbol_filter(struct map *map, struct symbol *sym)
}
}

if (!syme->skip)
syme->name_len = strlen(sym->name);

return 0;
}

Expand Down
5 changes: 3 additions & 2 deletions tools/perf/util/top.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ void perf_top__find_widths(struct perf_top *top, struct rb_root *root,

for (nd = rb_first(root); nd; nd = rb_next(nd)) {
struct sym_entry *syme = rb_entry(nd, struct sym_entry, rb_node);
struct symbol *sym = sym_entry__symbol(syme);

if (++printed > top->print_entries ||
(int)syme->snap_count < top->count_filter)
Expand All @@ -211,7 +212,7 @@ void perf_top__find_widths(struct perf_top *top, struct rb_root *root,
if (syme->map->dso->short_name_len > *dso_short_width)
*dso_short_width = syme->map->dso->short_name_len;

if (syme->name_len > *sym_width)
*sym_width = syme->name_len;
if (sym->namelen > *sym_width)
*sym_width = sym->namelen;
}
}
1 change: 0 additions & 1 deletion tools/perf/util/top.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ struct sym_entry {
unsigned long snap_count;
double weight;
int skip;
u16 name_len;
u8 origin;
struct map *map;
struct sym_entry_source *src;
Expand Down

0 comments on commit 764328d

Please sign in to comment.