Skip to content

Commit

Permalink
HID: remove hid-ff
Browse files Browse the repository at this point in the history
hid-ff.c now calls only pidff (generic driver), the special ones are now
in separate drivers. Invoke pidff on all non-special directly.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Slaby authored and Jiri Kosina committed Oct 14, 2008
1 parent 987fbc1 commit 76483cf
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 94 deletions.
13 changes: 0 additions & 13 deletions drivers/hid/usbhid/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -24,21 +24,8 @@ config USB_HID
comment "Input core support is needed for USB HID input layer or HIDBP support"
depends on USB_HID && INPUT=n

config HID_FF
bool "Force feedback support (EXPERIMENTAL)"
depends on USB_HID && EXPERIMENTAL
help
Say Y here is you want force feedback support for a few HID devices.
See below for a list of supported devices.

See <file:Documentation/input/ff.txt> for a description of the force
feedback API.

If unsure, say N.

config HID_PID
bool "PID device support"
depends on HID_FF
help
Say Y here if you have a PID-compliant device and wish to enable force
feedback for it. Microsoft Sidewinder Force Feedback 2 is one of such
Expand Down
3 changes: 0 additions & 3 deletions drivers/hid/usbhid/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ endif
ifeq ($(CONFIG_HID_PID),y)
usbhid-objs += hid-pidff.o
endif
ifeq ($(CONFIG_HID_FF),y)
usbhid-objs += hid-ff.o
endif

obj-$(CONFIG_USB_HID) += usbhid.o
obj-$(CONFIG_USB_KBD) += usbkbd.o
Expand Down
2 changes: 1 addition & 1 deletion drivers/hid/usbhid/hid-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ static int hid_probe(struct usb_interface *intf, const struct usb_device_id *id)
usb_set_intfdata(intf, hid);
hid->ll_driver = &usb_hid_driver;
hid->hid_output_raw_report = usbhid_output_raw_report;
hid->ff_init = hid_ff_init;
hid->ff_init = hid_pidff_init;
#ifdef CONFIG_USB_HIDDEV
hid->hiddev_connect = hiddev_connect;
hid->hiddev_hid_event = hiddev_hid_event;
Expand Down
69 changes: 0 additions & 69 deletions drivers/hid/usbhid/hid-ff.c

This file was deleted.

9 changes: 1 addition & 8 deletions include/linux/hid.h
Original file line number Diff line number Diff line change
Expand Up @@ -757,17 +757,10 @@ int usbhid_quirks_init(char **quirks_param);
void usbhid_quirks_exit(void);
void usbhid_set_leds(struct hid_device *hid);

#ifdef CONFIG_HID_FF
int hid_ff_init(struct hid_device *hid);

#ifdef CONFIG_HID_PID
int hid_pidff_init(struct hid_device *hid);
#else
static inline int hid_pidff_init(struct hid_device *hid) { return -ENODEV; }
#endif

#else
#define hid_ff_init NULL
#define hid_pidff_init NULL
#endif

#ifdef CONFIG_HID_DEBUG
Expand Down

0 comments on commit 76483cf

Please sign in to comment.