Skip to content

Commit

Permalink
[PATCH] stop leaking cfq_data in cfq_set_request()
Browse files Browse the repository at this point in the history
We don't need to pin ->key down; ->cfqq->cfqd will do that for us.
Incidentally, that stops the leak we had - that reference was never
dropped.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Mar 18, 2006
1 parent b0a6916 commit 7670876
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1433,7 +1433,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)
ioc->set_ioprio = cfq_ioc_set_ioprio;
cic->ioc = ioc;
cic->key = cfqd;
atomic_inc(&cfqd->ref);
} else {
struct cfq_io_context *__cic;

Expand Down Expand Up @@ -1469,7 +1468,6 @@ cfq_get_io_context(struct cfq_data *cfqd, pid_t pid, gfp_t gfp_mask)

__cic->ioc = ioc;
__cic->key = cfqd;
atomic_inc(&cfqd->ref);
list_add(&__cic->list, &cic->list);
cic = __cic;
}
Expand Down

0 comments on commit 7670876

Please sign in to comment.