Skip to content

Commit

Permalink
[SCSI] advansys: Remove a check for an impossible condition
Browse files Browse the repository at this point in the history
The midlayer guarantees it won't call ->queuecommand for a host which
is handling a reset condition.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
Matthew Wilcox authored and James Bottomley committed Oct 12, 2007
1 parent b662292 commit 7686f02
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions drivers/scsi/advansys.c
Original file line number Diff line number Diff line change
Expand Up @@ -3281,25 +3281,6 @@ advansys_queuecommand(struct scsi_cmnd *scp, void (*done) (struct scsi_cmnd *))
/* against own ISR */
spin_lock_irqsave(&boardp->lock, flags);

/*
* Block new commands while handling a reset or abort request.
*/
if (boardp->flags & ASC_HOST_IN_RESET) {
ASC_DBG1(1,
"advansys_queuecommand: scp 0x%lx blocked for reset request\n",
(ulong)scp);
scp->result = HOST_BYTE(DID_RESET);

/*
* Add blocked requests to the board's 'done' queue. The queued
* requests will be completed at the end of the abort or reset
* handling.
*/
asc_enqueue(&boardp->done, scp, ASC_BACK);
spin_unlock_irqrestore(&boardp->lock, flags);
return 0;
}

scp->scsi_done = done;
asc_res = asc_execute_scsi_cmnd(scp);
switch (asc_res) {
Expand Down

0 comments on commit 7686f02

Please sign in to comment.