Skip to content

Commit

Permalink
UBI: bugfix in sqnum calculation
Browse files Browse the repository at this point in the history
Hi,I came across problem of having two leb with same sequence no.This
happens when we continuously write one block again and again and reboot
machine before background thread erases those blocks.
The problem here was,when we find two blocks with same sequence no,we take
the higher one,but we were not updating max seq no,so next block may have
the same seqnum.
This patch solves this problem.

Signed-off-by: Brijesh Singh <brijesh.s.singh@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Brijesh Singh authored and Artem Bityutskiy committed Jul 18, 2007
1 parent 2f176f7 commit 76eafe4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/mtd/ubi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,9 @@ int ubi_scan_add_used(const struct ubi_device *ubi, struct ubi_scan_info *si,
if (IS_ERR(sv) < 0)
return PTR_ERR(sv);

if (si->max_sqnum < sqnum)
si->max_sqnum = sqnum;

/*
* Walk the RB-tree of logical eraseblocks of volume @vol_id to look
* if this is the first instance of this logical eraseblock or not.
Expand Down Expand Up @@ -563,9 +566,6 @@ int ubi_scan_add_used(const struct ubi_device *ubi, struct ubi_scan_info *si,
sv->last_data_size = be32_to_cpu(vid_hdr->data_size);
}

if (si->max_sqnum < sqnum)
si->max_sqnum = sqnum;

sv->leb_count += 1;
rb_link_node(&seb->u.rb, parent, p);
rb_insert_color(&seb->u.rb, &sv->root);
Expand Down

0 comments on commit 76eafe4

Please sign in to comment.