Skip to content

Commit

Permalink
iscsi-target: Fix uninitialized usage of cmd->pad_bytes
Browse files Browse the repository at this point in the history
This patch fixes an uninitialized usage of cmd->pad_bytes inside of
iscsit_handle_text_cmd() introduced during a v4.1 change to use cmd
members instead of local pad_bytes variables.

Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Nicholas Bellinger committed Jul 27, 2011
1 parent 8f50c7f commit 76f1928
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/target/iscsi/iscsi_target.c
Original file line number Diff line number Diff line change
Expand Up @@ -1857,7 +1857,7 @@ static int iscsit_handle_text_cmd(
char *text_ptr, *text_in;
int cmdsn_ret, niov = 0, rx_got, rx_size;
u32 checksum = 0, data_crc = 0, payload_length;
u32 padding = 0, text_length = 0;
u32 padding = 0, pad_bytes = 0, text_length = 0;
struct iscsi_cmd *cmd;
struct kvec iov[3];
struct iscsi_text *hdr;
Expand Down Expand Up @@ -1896,7 +1896,7 @@ static int iscsit_handle_text_cmd(

padding = ((-payload_length) & 3);
if (padding != 0) {
iov[niov].iov_base = cmd->pad_bytes;
iov[niov].iov_base = &pad_bytes;
iov[niov++].iov_len = padding;
rx_size += padding;
pr_debug("Receiving %u additional bytes"
Expand All @@ -1917,7 +1917,7 @@ static int iscsit_handle_text_cmd(
if (conn->conn_ops->DataDigest) {
iscsit_do_crypto_hash_buf(&conn->conn_rx_hash,
text_in, text_length,
padding, cmd->pad_bytes,
padding, (u8 *)&pad_bytes,
(u8 *)&data_crc);

if (checksum != data_crc) {
Expand Down

0 comments on commit 76f1928

Please sign in to comment.