Skip to content

Commit

Permalink
x86, mmiotrace: silence section mismatch warning - leave_uniprocessor
Browse files Browse the repository at this point in the history
WARNING: vmlinux.o(.text+0x180af): Section mismatch in reference from the function leave_uniprocessor() to the function .cpuinit.text:cpu_up()
The function leave_uniprocessor() references
the function __cpuinit cpu_up().
This is often because leave_uniprocessor lacks a __cpuinit
annotation or the annotation of cpu_up is wrong.

leave_uniprocessor calls cpu_up only when CONFIG_HOTPLUG_CPU is set,
so it can be safely annotated as __ref

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Pekka Paalanen <pq@iki.fi>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Paalanen <pq@iki.fi>
  • Loading branch information
Marcin Slusarz authored and Ingo Molnar committed Aug 21, 2008
1 parent bde78a7 commit 7701e8c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion arch/x86/mm/mmio-mod.c
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,9 @@ static void enter_uniprocessor(void)
"may miss events.\n");
}

static void leave_uniprocessor(void)
/* __ref because leave_uniprocessor calls cpu_up which is __cpuinit,
but this whole function is ifdefed CONFIG_HOTPLUG_CPU */
static void __ref leave_uniprocessor(void)
{
int cpu;
int err;
Expand Down

0 comments on commit 7701e8c

Please sign in to comment.