Skip to content

Commit

Permalink
jbd: need to hold j_state_lock to updates to transaction t_state to T…
Browse files Browse the repository at this point in the history
…_COMMIT

Updating the current transaction's t_state is protected by j_state_lock.  We
need to do the same when updating the t_state to T_COMMIT.

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Acked-by: Jan Kara <jack@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Mingming Cao authored and Linus Torvalds committed May 15, 2008
1 parent c3723ca commit 772279c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions fs/jbd/commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,9 @@ void journal_commit_transaction(journal_t *journal)
* transaction! Now comes the tricky part: we need to write out
* metadata. Loop over the transaction's entire buffer list:
*/
spin_lock(&journal->j_state_lock);
commit_transaction->t_state = T_COMMIT;
spin_unlock(&journal->j_state_lock);

J_ASSERT(commit_transaction->t_nr_buffers <=
commit_transaction->t_outstanding_credits);
Expand Down

0 comments on commit 772279c

Please sign in to comment.