Skip to content

Commit

Permalink
drbd: prepare to activate two activity log extents at once
Browse files Browse the repository at this point in the history
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
  • Loading branch information
Lars Ellenberg authored and Philipp Reisner committed Nov 8, 2012
1 parent 181286a commit 7726547
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions drivers/block/drbd/drbd_actlog.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,22 @@ static struct lc_element *_al_get(struct drbd_conf *mdev, unsigned int enr)

void drbd_al_begin_io(struct drbd_conf *mdev, struct drbd_interval *i)
{
unsigned int enr = (i->sector >> (AL_EXTENT_SHIFT-9));
struct lc_element *al_ext;
/* for bios crossing activity log extent boundaries,
* we may need to activate two extents in one go */
unsigned int enr[2];
struct lc_element *al_ext[2] = { NULL, NULL };
struct update_al_work al_work;

D_ASSERT(atomic_read(&mdev->local_cnt) > 0);

wait_event(mdev->al_wait, (al_ext = _al_get(mdev, enr)));
enr[0] = i->sector >> (AL_EXTENT_SHIFT-9);
enr[1] = (i->sector + (i->size >> 9) - 1) >> (AL_EXTENT_SHIFT-9);
wait_event(mdev->al_wait, (al_ext[0] = _al_get(mdev, enr[0])));
if (enr[0] != enr[1])
wait_event(mdev->al_wait, (al_ext[1] = _al_get(mdev, enr[1])));

if (al_ext->lc_number != enr) {
if (al_ext[0]->lc_number != enr[0] ||
(al_ext[1] && al_ext[1]->lc_number != enr[1])) {
/* drbd_al_write_transaction(mdev,al_ext,enr);
* recurses into generic_make_request(), which
* disallows recursion, bios being serialized on the
Expand All @@ -232,7 +239,8 @@ void drbd_al_begin_io(struct drbd_conf *mdev, struct drbd_interval *i)

/* Double check: it may have been committed by someone else,
* while we have been waiting for the lock. */
if (al_ext->lc_number != enr) {
if (al_ext[0]->lc_number != enr[0] ||
(al_ext[1] && al_ext[1]->lc_number != enr[1])) {
init_completion(&al_work.event);
al_work.w.cb = w_al_write_transaction;
al_work.w.mdev = mdev;
Expand Down

0 comments on commit 7726547

Please sign in to comment.