Skip to content

Commit

Permalink
[SCSI] scsi_scan.c: Release mutex in error handling code
Browse files Browse the repository at this point in the history
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
... when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Julia Lawall authored and James Bottomley committed Jul 26, 2008
1 parent 1226570 commit 773e82f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/scsi/scsi_scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1760,6 +1760,7 @@ static void scsi_finish_async_scan(struct async_scan_data *data)
printk("%s called twice for host %d", __FUNCTION__,
shost->host_no);
dump_stack();
mutex_unlock(&shost->scan_mutex);
return;
}

Expand Down

0 comments on commit 773e82f

Please sign in to comment.