Skip to content

Commit

Permalink
UBI: use is_power_of_2()
Browse files Browse the repository at this point in the history
Replacing (n & (n-1)) in the context of power of 2 checks
with is_power_of_2

Signed-off-by: Vignesh Babu <vignesh.babu@wipro.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Vignesh Babu authored and Artem Bityutskiy committed Jul 18, 2007
1 parent d7f0c4d commit 7753f16
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mtd/ubi/build.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include <linux/moduleparam.h>
#include <linux/stringify.h>
#include <linux/stat.h>
#include <linux/log2.h>
#include "ubi.h"

/* Maximum length of the 'mtd=' parameter */
Expand Down Expand Up @@ -422,8 +423,7 @@ static int io_init(struct ubi_device *ubi)
ubi->hdrs_min_io_size = ubi->mtd->writesize >> ubi->mtd->subpage_sft;

/* Make sure minimal I/O unit is power of 2 */
if (ubi->min_io_size == 0 ||
(ubi->min_io_size & (ubi->min_io_size - 1))) {
if (!is_power_of_2(ubi->min_io_size)) {
ubi_err("bad min. I/O unit");
return -EINVAL;
}
Expand Down

0 comments on commit 7753f16

Please sign in to comment.