Skip to content

Commit

Permalink
KVM: opencode gfn_to_page in kvm_vm_fault
Browse files Browse the repository at this point in the history
kvm_vm_fault is invoked with mmap_sem held in read mode. Since gfn_to_page
will be converted to get_user_pages_fast, which requires this lock NOT
to be held, switch to opencoded get_user_pages.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Marcelo Tosatti authored and Avi Kivity committed Oct 15, 2008
1 parent bfadade commit 777b3f4
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions virt/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1394,17 +1394,22 @@ static long kvm_vm_ioctl(struct file *filp,

static int kvm_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
{
struct page *page[1];
unsigned long addr;
int npages;
gfn_t gfn = vmf->pgoff;
struct kvm *kvm = vma->vm_file->private_data;
struct page *page;

if (!kvm_is_visible_gfn(kvm, vmf->pgoff))
addr = gfn_to_hva(kvm, gfn);
if (kvm_is_error_hva(addr))
return VM_FAULT_SIGBUS;
page = gfn_to_page(kvm, vmf->pgoff);
if (is_error_page(page)) {
kvm_release_page_clean(page);

npages = get_user_pages(current, current->mm, addr, 1, 1, 0, page,
NULL);
if (unlikely(npages != 1))
return VM_FAULT_SIGBUS;
}
vmf->page = page;

vmf->page = page[0];
return 0;
}

Expand Down

0 comments on commit 777b3f4

Please sign in to comment.