Skip to content

Commit

Permalink
rtc_hctosys expects RTCs in UTC (doc)
Browse files Browse the repository at this point in the history
The RTC "hctosys" mechanism expects that RTC clock will use UTC, not local
time (e.g.  PST).  Say so in Kconfig and in the kernel message.

(Strictly speaking, the RTC clock should be tracking the POSIX epoch.  That's
not worth going into here.  Goofing timezones means clocks are wrong by many
hours; the POSIX-v-UTC differences just cost seconds.)

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
David Brownell authored and Linus Torvalds committed Nov 15, 2007
1 parent 1299342 commit 779d208
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion drivers/rtc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ config RTC_HCTOSYS_DEVICE
help
The RTC device that will be used to (re)initialize the system
clock, usually rtc0. Initialization is done when the system
starts up, and when it resumes from a low power state.
starts up, and when it resumes from a low power state. This
device should record time in UTC, since the kernel won't do
timezone correction.

The driver for this RTC device must be loaded before late_initcall
functions run, so it must usually be statically linked.
Expand Down
4 changes: 2 additions & 2 deletions drivers/rtc/hctosys.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ static int __init rtc_hctosys(void)
do_settimeofday(&tv);

dev_info(rtc->dev.parent,
"setting the system clock to "
"%d-%02d-%02d %02d:%02d:%02d (%u)\n",
"setting system clock to "
"%d-%02d-%02d %02d:%02d:%02d UTC (%u)\n",
tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday,
tm.tm_hour, tm.tm_min, tm.tm_sec,
(unsigned int) tv.tv_sec);
Expand Down

0 comments on commit 779d208

Please sign in to comment.